Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorthand HugrView method for "connected port" #499

Closed
ss2165 opened this issue Sep 6, 2023 · 0 comments · Fixed by #680
Closed

Shorthand HugrView method for "connected port" #499

ss2165 opened this issue Sep 6, 2023 · 0 comments · Fixed by #680
Assignees
@ss2165
Labels
enhancement New feature or request

Comments

@ss2165
Copy link
Member

ss2165 commented Sep 6, 2023 •
edited
Loading

Lots of places where we write things like:

  let (node, port) = h
      .linked_ports(node, port)
      .exactly_one()
      .ok()
      .unwrap();

And we are happy to unwrap because by linearity we know we can, so maybe a linear_linked_port method?
@ss2165 ss2165 added the enhancement New feature or request label Sep 6, 2023
@ss2165 ss2165 mentioned this issue Sep 7, 2023
Closed
@croyzor croyzor self-assigned this Sep 20, 2023
@ss2165 ss2165 assigned ss2165 and unassigned croyzor Nov 9, 2023
ss2165 added a commit that referenced this issue Nov 13, 2023
@ss2165
feat: single_source/target for when you know only one connected port
6094663 
Closes Shorthand HugrView method for "connected port" #499
@ss2165 ss2165 mentioned this issue Nov 13, 2023
Merged
8 tasks
ss2165 added a commit that referenced this issue Nov 13, 2023
@ss2165
feat: single_source/target for when you know only one connected port
110ce33 
Closes Shorthand HugrView method for "connected port" #499
ss2165 added a commit that referenced this issue Nov 13, 2023
@ss2165
feat: single_source/target for when you know only one connected port
2ffd29a 
Closes Shorthand HugrView method for "connected port" #499
github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2023
@ss2165
feat!: HugrView API improvements (#680)
e943fdc 
- [x] Closes #495
- [x] Closes #521
- [x] Closes #655
- [x] Closes #499
- [x] Closes #506 
- [x] Closes #653
- [x] `OpType::signature` returns option (non-dataflow ops don't return
signature)
- [x] Implement `try_into` from OpType references in to inner
references.

Doesn't necessarily do exactly as those issues specify - instead
considers them holistically for a more unified interface. Easiest to
review commit by commit.

Uses rust_version crate to use return position impl for the new
`HugrView` methods that return iterators. This will be stable with 1.75
(which enters beta in a few days).

BREAKING_CHANGES: `OpType` and `FunctionType` methods renamed for
clarity; `OpType::signature` returns `Option<FuncType>`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: HugrView API improvements CQCL/hugr
2 participants
@croyzor @ss2165