Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code in src/middleware/admin.js to reduce cognitive complexity from 19 to 15 #406

Open
wants to merge 41 commits into
base: f24
Choose a base branch
from
Open

Refactoring code in src/middleware/admin.js to reduce cognitive complexity from 19 to 15 #406

wants to merge 41 commits into from

Commits on Sep 3, 2024

  1. breakdwon into main function and helper functions

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1eb340f View commit details
    Browse the repository at this point in the history

  2. Add helper functions hasNoPassword and handleReLogin

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a8e1e8f View commit details
    Browse the repository at this point in the history

  3. Added helperfunctions extendLogoutTimer and redirectToLogin

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2cde40d View commit details
    Browse the repository at this point in the history

  4. fix grammer errors

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    af1548e View commit details
    Browse the repository at this point in the history

  5. correct the use of "async" for the main function

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4cd25a5 View commit details
    Browse the repository at this point in the history

  6. updated grammar issues including spaces and indentation

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7e73b66 View commit details
    Browse the repository at this point in the history

  7. fixed line 31 function grammar

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c461b24 View commit details
    Browse the repository at this point in the history

  8. fix the wrong function grammar =>

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    88ebcea View commit details
    Browse the repository at this point in the history

  9. updated grammar issues like function expression and space

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f1c4ed9 View commit details
    Browse the repository at this point in the history

  10. deleting trailing space

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    87d4594 View commit details
    Browse the repository at this point in the history

  11. simplify the logics

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e4e4d43 View commit details
    Browse the repository at this point in the history

  12. missing bracket

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ff76571 View commit details
    Browse the repository at this point in the history

  13. recover

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    beb3c33 View commit details
    Browse the repository at this point in the history

  14. correct the duplicate error

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a7e11d8 View commit details
    Browse the repository at this point in the history

  15. delete brackets

    @Driftedboat
    Driftedboat authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    696bf7e View commit details
    Browse the repository at this point in the history

  16. added test cases

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ff928a8 View commit details
    Browse the repository at this point in the history

  17. Merge remote-tracking branch 'origin/feature' into feature

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    14aa1d9 View commit details
    Browse the repository at this point in the history

  18. changed test cases

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    bcd2843 View commit details
    Browse the repository at this point in the history

  19. changed tests 2

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    adb0ee9 View commit details
    Browse the repository at this point in the history

  20. changed tests 3

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    725d1b3 View commit details
    Browse the repository at this point in the history

  21. added sinon

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6722ac4 View commit details
    Browse the repository at this point in the history

  22. added plugin

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    23bbc30 View commit details
    Browse the repository at this point in the history

  23. added admin

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    150addd View commit details
    Browse the repository at this point in the history

  24. added test cases for redirect

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ce21903 View commit details
    Browse the repository at this point in the history

  25. back to orignial test cases

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    51fd2c8 View commit details
    Browse the repository at this point in the history

  26. remove redirect

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    74314a1 View commit details
    Browse the repository at this point in the history

  27. remove sinon

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c76bf68 View commit details
    Browse the repository at this point in the history

  28. coment out

    @Driftedboat
    Driftedboat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    77663fb View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. fix coverage issue

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f2b95e4 View commit details
    Browse the repository at this point in the history

  2. get rid of promise expression

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    4bc9e2c View commit details
    Browse the repository at this point in the history

  3. add callback logics

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fa9f8ae View commit details
    Browse the repository at this point in the history

  4. fix relogin

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b742a86 View commit details
    Browse the repository at this point in the history

  5. fix relogin2

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e16bee2 View commit details
    Browse the repository at this point in the history

  6. fix callback2

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0522dc5 View commit details
    Browse the repository at this point in the history

  7. format fix

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e289d96 View commit details
    Browse the repository at this point in the history

  8. format fix2

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0d66fa2 View commit details
    Browse the repository at this point in the history

  9. format fix3

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b7f33e6 View commit details
    Browse the repository at this point in the history

  10. add print statement

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bedf212 View commit details
    Browse the repository at this point in the history

  11. single quotation

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0cd4f5c View commit details
    Browse the repository at this point in the history

  12. no comments

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b4d4296 View commit details
    Browse the repository at this point in the history

  13. git rid of unused const

    @Driftedboat
    Driftedboat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8fc7c2a View commit details
    Browse the repository at this point in the history