Refactoring code in src/middleware/admin.js to reduce cognitive complexity from 19 to 15

[Driftedboat]

Overall Description

The code I refractored resolved the issue #371. In order to reduce the cognitive complexity from 19 to below 15, I break down the function by using several helper functions. The helper functions include isAccessDenied, hasNoPassword, handleReLogin, and extendLogOutTimer.

Manual Testing

The admin.js file inside middleware is mainly set up for checking the priviledge of the administrator, setting threshold.

To trigger the refractored code in UI, go to the "homepage"->then "groups" -> then choose an "administrator" -> then click on "administrator control panel".

Log Screenshot

The printing statement is embeded in the refractored code and here is the log screenshot. The statement is on the last line:

Coverage

Overall the coverage maintained and passed the check. The tests covered almost all the lines of code, except for part of the callback and next logics inside the code file.

The lines, callbacks and next() calls, are difficult to fully cover because they depend on specific conditions, like errors or unusual data states, which are hard to simulate reliably in tests. In addition, the asynchronous nature of callbacks also introduces side effects, causing the function to exit or alter flow unexpectedly, making these lines particularly challenging to reach compared to other code.

[coveralls]

Pull Request Test Coverage Report for Build 10729957510

Details

• 25 of 30 (83.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.04%) to 82.709%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/middleware/admin.js	25	30	83.33%

Totals
Change from base Build 10607818019:	0.04%
Covered Lines:	22336
Relevant Lines:	25586

---

💛 - Coveralls

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud