Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sound settings update script to reduce nested functions (src/upgrades/1.4.4/sound_settings.js) #90

Open
wants to merge 5 commits into
base: f24
Choose a base branch
from

Conversation

Seckhen
Copy link

@Seckhen Seckhen commented Sep 4, 2024

This refactor reduces the depth of nested functions in the sound settings update script to no more than 4 levels. Key changes include breaking the logic for updating global and user-specific sound settings into separate functions (updateGlobalSoundSettings and updateUserSoundSettings).

Resolved #84

@coveralls
Copy link

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10724791966

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 82.689%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10550029021: 0.02%
Covered Lines: 22329
Relevant Lines: 25582

💛 - Coveralls

@Seckhen Seckhen changed the title Refactor sound settings update script to reduce nested functions Refactor sound settings update script to reduce nested functions (src/upgrades/1.4.4/sound_settings.js) Sep 5, 2024
Copy link

sonarqubecloud bot commented Sep 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring code in src/upgrades/1.4.4/sound_settings.js
2 participants