Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py-gt4py, py-icon4py] Renaming gt4py versions + Adding icon4py v0.0.3.1 to latest #835

Merged
merged 31 commits into from
Oct 19, 2023
Merged

[py-gt4py, py-icon4py] Renaming gt4py versions + Adding icon4py v0.0.3.1 to latest #835

merged 31 commits into from
Oct 19, 2023

Conversation

abishekg7
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-19 17:07 UTC

@abishekg7
Copy link
Contributor Author

launch jenkins py-icon4py py-gt4py

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary

WARNING: Serial tests did not run for system tests

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary

WARNING: Serial tests did not run for system tests

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary

WARNING: Serial tests did not run for system tests

@abishekg7
Copy link
Contributor Author

launch jenkins py-icon4py py-gt4py

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🔴 system test
Test
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_2
🔴PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
🔴PyIcon4py-install_version_0_0_7
🔴PyIcon4py-install_version_0_0_8

WARNING: Serial tests did not run for system tests

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🔴 system test
Test
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_2
🔴PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
🔴PyIcon4py-install_version_0_0_7
🔴PyIcon4py-install_version_0_0_8

WARNING: Serial tests did not run for system tests

@abishekg7
Copy link
Contributor Author

launch jenkins py-icon4py py-gt4py

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🟢 system test
Test
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_2
🟢PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
🟢PyIcon4py-install_version_0_0_7
🟢PyIcon4py-install_version_0_0_8

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🟢 system test
Test
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_2
🟢PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
🟢PyIcon4py-install_version_0_0_7
🟢PyIcon4py-install_version_0_0_8

@abishekg7 abishekg7 changed the title Patch for icon4py v0.0.3 [py-gt4py, py-icon4py] Renaming gt4py versions + Adding icon4py v0.0.3.1 to latest Oct 3, 2023
@abishekg7 abishekg7 requested a review from mjaehn October 3, 2023 07:00
@abishekg7 abishekg7 force-pushed the patch_icon4py_v0.0.3 branch from f7f824c to 4b56ed3 Compare October 16, 2023 07:05
@abishekg7
Copy link
Contributor Author

launch jenkins py-icon4py py-gt4py icon

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🔴 system test
Test
🔴Icon-install_2_6_6_gcc
🔴Icon-install_2_6_6_nvhpc
🔴Icon-install_nwp_gpu
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_1b
🟢PyGt4py-install_version_1_0_1_2
🟢PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
🟢PyIcon4py-install_version_0_0_7

WARNING: Serial tests did not run for system tests

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🔴 system test
Test
🟢Icon-install_2_6_6_gcc
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_1b
🟢PyGt4py-install_version_1_0_1_2
🟢PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
⌛PyIcon4py-install_version_0_0_7 slurm time limit
🟢daint_cpu_cce
🟢daint_cpu_gcc
🟢daint_cpu_nvhpc
🟢daint_cpu_nvhpc_out_of_source
🟢daint_gpu_nvhpc
🔴daint_dsl_nvhpc

WARNING: Serial tests did not run for system tests

@abishekg7
Copy link
Contributor Author

launch jenkins py-icon4py py-gt4py icon

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🟢 system test
Test
🟢Icon-install_2_6_6_gcc
🟢Icon-install_2_6_6_nvhpc
🟢Icon-install_nwp_gpu
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_1b
🟢PyGt4py-install_version_1_0_1_2
🟢PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
🟢PyIcon4py-install_version_0_0_7

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🔴 system test
Test
🟢Icon-install_2_6_6_gcc
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_1b
🟢PyGt4py-install_version_1_0_1_2
🟢PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
🟢PyIcon4py-install_version_0_0_7
🔴daint_cpu_cce
🔴daint_cpu_gcc
🔴daint_cpu_nvhpc
🔴daint_cpu_nvhpc_out_of_source
🔴daint_gpu_nvhpc
🔴daint_dsl_nvhpc

WARNING: Serial tests did not run for system tests

@abishekg7
Copy link
Contributor Author

@jonasjucker I'm not understanding why the daint tests are failing at the concretization step. That too I only changed the dsl test, not the others. Any ideas?

@jonasjucker
Copy link
Contributor

@abishekg7 Not your fault, rather the consequence of #829
and spack/spack#40449

@abishekg7
Copy link
Contributor Author

Ah interesting! Okay, so I'm trying to build the icon-dsl versions (latest and older tag) locally on Daint. I'm also building the older tag of icon-dsl, so that I can test my icon4py path mapping for v0.0.3:0.0.3.1. Will let you know when the builds proceed fine.

Other than that, this PR is fine I believe.

@abishekg7
Copy link
Contributor Author

launch jenkins py-icon4py py-gt4py icon

@jenkins-apn
Copy link

tsa

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🟢 system test
Test
🟢Icon-install_2_6_6_gcc
🟢Icon-install_2_6_6_nvhpc
🟢Icon-install_nwp_gpu
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_1b
🟢PyGt4py-install_version_1_0_1_2
🟢PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
🟢PyIcon4py-install_version_0_0_7

@jenkins-apn
Copy link

daint

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢icon-spack_info
🟢icon-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create_claw=std-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🟢 system test
Test
🟢Icon-install_2_6_6_gcc
🟢PyGt4py-install_version_1_0_1_1
🟢PyGt4py-install_version_1_0_1_1b
🟢PyGt4py-install_version_1_0_1_2
🟢PyGt4py-install_version_1_0_1_4
🟢PyIcon4py-install_version_0_0_3
🟢PyIcon4py-install_version_0_0_5
🟢PyIcon4py-install_version_0_0_6
🟢PyIcon4py-install_version_0_0_7
🟢daint_cpu_cce
🟢daint_cpu_gcc
🟢daint_cpu_nvhpc
🟢daint_cpu_nvhpc_out_of_source
🟢daint_gpu_nvhpc
🟢daint_dsl_nvhpc

@abishekg7
Copy link
Contributor Author

Just an update, my local icon-dsl builds work with these name changes. For both the latest and older tag. And I also removed the '-' from the branch name, so the CI is working now.

These are corresponding PRs in icon, icon4py
https://github.com/C2SM/icon/pull/73
C2SM/icon4py#293

jonasjucker
jonasjucker reviewed Oct 19, 2023
View reviewed changes
test/system_test.py Outdated Show resolved Hide resolved
jonasjucker
jonasjucker reviewed Oct 19, 2023
View reviewed changes
test/system_test.py Outdated Show resolved Hide resolved
jonasjucker
jonasjucker approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jonasjucker jonasjucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged your update in C2SM/icon, therefore revert your tmp-path to your fork in system_test.py.

Rest looks good. Thank you for cleaning up these sins of the past!

@jonasjucker
Copy link
Contributor

You can merge :-)

@abishekg7 abishekg7 merged commit 8829176 into main Oct 19, 2023
3 checks passed
@abishekg7 abishekg7 deleted the patch_icon4py_v0.0.3 branch October 19, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasjucker jonasjucker jonasjucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abishekg7 @jenkins-apn @mjaehn @jonasjucker