Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing CI #633

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix for failing CI #633

merged 1 commit into from
Jan 7, 2025

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Jan 7, 2025

Fix for module usage in test file after #614 was merged.

Copy link

github-actions bot commented Jan 7, 2025

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@edopao
Copy link
Contributor Author

edopao commented Jan 7, 2025

cscs-ci run default

@edopao
Copy link
Contributor Author

edopao commented Jan 7, 2025

cscs-ci run benchmark

@edopao edopao requested a review from egparedes January 7, 2025 12:55
@havogt
Copy link
Contributor

havogt commented Jan 7, 2025

This is already in #632

Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for finding and fixing this bug!

@edopao edopao merged commit fb4ea77 into main Jan 7, 2025
4 checks passed
@edopao edopao deleted the fix-ci branch January 7, 2025 14:27
OngChia pushed a commit that referenced this pull request Jan 14, 2025
Fix for module usage in test file after #614 was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants