Update dev tooling #614
Draft
Update dev tooling #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egparedes
force-pushed
the
update-dev-tooling
branch
from
07272f4 to
87fe070
Compare
egparedes
force-pushed
the
update-dev-tooling
branch
from
f26b688 to
fb8fe5f
Compare
egparedes
force-pushed
the
update-dev-tooling
branch
from
fb8fe5f to
6c48671
Compare
halungge
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Did you delete the test_utils folder as well? Looks like it is still there, but git sometimes messes up deleted empty folders. It should be empty, right?
model/common/tests/metric_tests/test_compute_diffusion_metrics.py
Outdated
Show resolved
Hide resolved
model/common/tests/metric_tests/test_compute_diffusion_metrics.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/metrics/compute_coeff_gradekin.py
Outdated
Show resolved
Hide resolved
model/common/src/icon4py/model/common/metrics/compute_coeff_gradekin.py
Outdated
Show resolved
Hide resolved
edopao
reviewed
Dec 13, 2024
| # workspace members | ||
| 'icon4py-common[netcdf]>=0.0.6', | ||
| # external dependencies | ||
| "gt4py>=1.0.4", |
There was a problem hiding this comment.
Should we maybe install gt4py[dace] for testing? Please see my changes in #600.
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
Open
halungge
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.