Porting the tracer advection to gt4py #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Erwan Cossevin <[email protected]> Co-authored-by: Stephanie Westerhuis <[email protected]>
* run pre-commit * fix hflx_limiter_pd_stencil_01
* adding hflx_limiter_mo_stencil_02 * changes order of args and return a tuple * Revert "changes order of args and return a tuple" This reverts commit 99638df. * porting step_advection_stencil_01 * porting step_advection_stencil_02 * porting upwind_hflux_miura_stencil_02 * hflx_limiter_mo_stencil_04 * fix step_advection_stencil_01 * hflx_limiter_mo_stencil_03 * clean up: move upwind_hflux_miura_stencil_02.py * add test for conditional branch in hflx_limiter_mo_stencil_04 * switch to using min_over in hflx_limiter_mo_stencil_03 * refactor hflx_limiter_mo_stencil_04, fix tests for Koffset * add upwind_vflux_ppm_stencil_01 * upwind_hflux_miura_stencil_02 - fix sparse field issue, split into separate sums instead of using neighbor_sum * remove commented out code * fix: upwind_vflux_ppm_stencil_01 * fix: hflx_limiter_mo_stencil_01: return tuple, use int32 * hflx_limiter_pd_stencil_02.py: use int fields
Co-authored-by: Magdalena Luz <[email protected]> Co-authored-by: Nicoletta Farabullini <[email protected]>
* fixing return type * removing broadcast
(feat) - stencil to set field to zero for Field[[CellDim], float] and Field[[CellDim, KDim], float]
egparedes
reviewed
Sep 4, 2023
added 3 commits
September 8, 2023 08:19
…cils Conflicts: model/atmosphere/dycore/src/icon4py/model/atmosphere/dycore/mo_velocity_advection_stencil_18.py model/atmosphere/dycore/src/icon4py/model/atmosphere/dycore/mo_velocity_advection_stencil_20.py model/common/src/icon4py/model/common/test_utils/simple_mesh.py tools/pyproject.toml
|
launch jenkins spack |
|
launch jenkins spack |
merging of greenline with main
* add option to use custom spack-c2sm branch for spack tests * fix missing declarations * fix missing declarations --------- Co-authored-by: Jonas Jucker <[email protected]>
This fixes test references where the current implementation assumes a certain behavior of the backend. Specifically, we used np.roll in the references and the backend (by chance) had the same wrap-around behavior. For an upcoming PR in GT4Py, we need to remove that expectation. --------- Co-authored-by: Jonas Jucker <[email protected]> Co-authored-by: juckerj <[email protected]> Co-authored-by: Abishek Gopal <[email protected]>
Fix static typing annotations in icon4pytools.
This PR allows to use the DELETE statements only for the fused stencil mode. --------- Co-authored-by: Samuel <[email protected]>
ninaburg
force-pushed
the
tracer_advection_stencils
branch
from
57852e5 to
d4436c0
Compare
…cils Conflicts: .github/workflows/icon4py-qa.yml model/README.md model/common/src/icon4py/model/common/test_utils/simple_mesh.py model/requirements-dev.txt model/requirements.txt model/tox.ini requirements.txt tools/requirements-dev.txt tox.ini
|
launch jenkins spack |
|
launch jenkins spack spackProject=C2SM/pyicon4py_with_advection |
1 similar comment
|
launch jenkins spack spackProject=C2SM/pyicon4py_with_advection |
egparedes
approved these changes
Sep 28, 2023
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
launch jenkins spack spackProject=C2SM/pyicon4py_with_advection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting and integrating the stencils that are in the operational code path of the tracer advection according to the namelist:
Exceptions: 3
DO WHILEloops inmo_advection_vflux.f90couldn't be ported.TODO when
ASYNC(1)are added toadvection/mo_advection_quadrature.f90:TODO when multiple stencils can be used with different
KDim_sizeinCMakelists.txt:dsl_advection_cyclingRemark:
__init__.pyfiles have been deleted in the tests folders indycoreandadvection. Otherwisepytestinmodel/wouldn't work. Another alternative would have been to rename the tests folderstests_dycore/andtests_advection/. This is still to be discussed. EDIT: Changing the names of the folders to<components>_testsas in https://github.com/C2SM/icon4py/pull/260/files#diff-8bce9783214998f11bc562a6e5619e3f25287303b4d210afe4ed6115f80b1c05 has been chosen (see comments)