Fix v_limit_prbl_sm_stencil_01 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halungge
requested changes
Oct 14, 2022
| @@ -31,7 +31,7 @@ | |||
| def _v_limit_prbl_sm_stencil_01( | |||
| p_face: Field[[CellDim, KDim], float], | |||
| p_cc: Field[[CellDim, KDim], float], | |||
| ) -> Field[[CellDim, KDim], float]: | |||
| ) -> tuple[Field[[CellDim, KDim], float], Field[[CellDim, KDim], float]]: | |||
There was a problem hiding this comment.
the return type is fine,
but below do you need the broadcast? you are then reassigning in the where..
There was a problem hiding this comment.
yeah, not strictly necessary. will remove
halungge
approved these changes
Oct 14, 2022
ninaburg
pushed a commit
that referenced
this pull request
Nov 29, 2022
* fixing return type * removing broadcast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.