Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR types to run actions #228

Merged
merged 7 commits into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/icon4py-qa.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: ICON4Py Quality Assurance

on:
workflow_dispatch:
push:
branches:
- main
Expand All @@ -9,6 +10,9 @@ on:
pull_request:
branches:
- main
types: [opened, reopened, assigned, ready_for_review]
pull_request_review:
types: [submitted, edited]

jobs:
pre-commit:
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/icon4py-tox.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: ICON4Py Tox

on:
workflow_dispatch:
push:
branches:
- main
Expand All @@ -9,7 +10,9 @@ on:
pull_request:
branches:
- main

types: [opened, reopened, assigned, ready_for_review]
pull_request_review:
types: [submitted, edited]
jobs:
tox-tests:
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/icon4pytools-qa.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: ICON4PyTools Quality Assurance

on:
workflow_dispatch:
push:
branches:
- main
Expand All @@ -10,6 +11,9 @@ on:
pull_request:
branches:
- main
types: [opened, reopened, assigned, ready_for_review]
pull_request_review:
types: [submitted, edited]

jobs:
pre-commit:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/icon4pytools-tox.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: ICON4PyTools Tox

on:
workflow_dispatch:
push:
branches:
- main
Expand All @@ -10,6 +11,9 @@ on:
pull_request:
branches:
- main
types: [opened, reopened, assigned, ready_for_review]
pull_request_review:
types: [submitted, edited]

jobs:
tox-tests:
Expand Down
9 changes: 0 additions & 9 deletions atm_dyn_iconam/tests/test_mo_solve_nonhydro_stencil_20.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,6 @@ def test_mo_solve_nonhydro_stencil_20():
np.asarray(z_dexner_dz_c_2),
)

hstart = 0
hend = mesh.n_edges
kstart = 0
kend = mesh.k_level

mo_solve_nonhydro_stencil_20(
inv_dual_edge_length,
z_exner_ex_pr,
Expand All @@ -114,10 +109,6 @@ def test_mo_solve_nonhydro_stencil_20():
z_dexner_dz_c_1,
z_dexner_dz_c_2,
z_gradh_exner,
hstart,
hend,
kstart,
kend,
offset_provider={
"E2C": mesh.get_e2c_offset_provider(),
"E2EC": StridedNeighborOffsetProvider(EdgeDim, ECDim, mesh.n_e2c),
Expand Down
9 changes: 0 additions & 9 deletions atm_dyn_iconam/tests/test_mo_solve_nonhydro_stencil_21.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,6 @@ def test_mo_solve_nonhydro_stencil_21():
grav_o_cpd,
)

hstart = 0
hend = mesh.n_edges
kstart = 0
kend = mesh.k_level

mo_solve_nonhydro_stencil_21(
theta_v,
ikoffset_new,
Expand All @@ -137,10 +132,6 @@ def test_mo_solve_nonhydro_stencil_21():
inv_dual_edge_length,
grav_o_cpd,
z_hydro_corr,
hstart,
hend,
kstart,
kend,
offset_provider={
"E2C": mesh.get_e2c_offset_provider(),
"E2EC": StridedNeighborOffsetProvider(EdgeDim, ECDim, mesh.n_e2c),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,6 @@ def test_mo_nh_diffusion_stencil_15():
np.asarray(z_temp),
)

hstart = 0
hend = mesh.n_cells
kstart = 0
kend = mesh.k_level

truly_horizontal_diffusion_nabla_of_theta_over_steep_points(
mask,
zd_vertoffset_new,
Expand All @@ -120,10 +115,6 @@ def test_mo_nh_diffusion_stencil_15():
vcoef_new,
theta_v,
z_temp,
hstart,
hend,
kstart,
kend,
offset_provider={
"C2E2C": mesh.get_c2e2c_offset_provider(),
"C2CEC": StridedNeighborOffsetProvider(CellDim, CECDim, mesh.n_c2e2c),
Expand Down