PR types to run actions

[halungge]

Github actions will not longer be triggered upon each sync of the PR, but only on these states:

• opened
• reopened
• assigned
• ready_for_review

My reasoning was: the author want so to have feedback when she opens the PR in the first place and when it is converted from draft -> full PR.

[jonasjucker]

Thank you.
I will watch our billing-units in the next couple of days to see the impact.

[havogt]

This will not run after pushes during review, i.e. no way to trigger before merge and therefore not possible to set-up branch protection rules (which we currently don't have). It seems with this setup, one might accidentally merge broken code.

Adding manual triggers + branch protection rules could solve that, but the manual trigger UI is not very handy (action -> select action -> run workflow -> select branch -> start).

[jonasjucker]

What about that:
https://github.com/Khan/pull-request-comment-trigger

[halungge]

We could also add a pull_request_review trigger:

on:
  pull_request_review:
    types: [submitted, edited]

This would trigger a run by the action of the reviewer I guess not necessarily pushes to the repository.
or even on changes on individual PR comments with

on: 
  pull_request_review_comment:
    types: [created, edited]

[halungge]

And why not enable branch protection rules? Is there any reason we don't have it?
In icon-exclaim we use some kind of comment trigger with the launch jenkins comment, right? That is definitely nicer than triggering from the UI...

[jonasjucker]

So any progress here?

If you don't find a solution I have to disable action for this repo to keep a minimum of resources for other repos.

[halungge]

check test fixes

[samkellerhals]

This will not run after pushes during review, i.e. no way to trigger before merge and therefore not possible to set-up branch protection rules (which we currently don't have). It seems with this setup, one might accidentally merge broken code.

Adding manual triggers + branch protection rules could solve that, but the manual trigger UI is not very handy (action -> select action -> run workflow -> select branch -> start).

I agree here, currently in the situation where I would like QA and tests to run before merging...