Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.2.0 #157

Merged
merged 5 commits into from
Sep 22, 2016
Merged

V2.2.0 #157

merged 5 commits into from
Sep 22, 2016

Conversation

doug-martin
Copy link
Contributor

Alex Tsibulya and others added 5 commits September 21, 2016 18:00
Test issue 150
16b7a8e 
- Add a test for issue #150 to specify the expected behavior
- Mark it `skip` pending implementation
Test split CRLF
43c6d6a 
- Add a test for CRLF split between two buffers (a.k.a issue #150) to
  specify the expected behavior
- Mark it `skip` pending implementation
Test ambiguous CR
8d63d59 
- Modify existing tests for `\r` row delimiter to specify the behavior
  in case of CR vs.CRLF ambiguity issue #150
- Mark them `skip` pending implementation
Keep the line if a new line is ambiguous
0b9b82b 
Modify the parser to
- parse CRLF as a single token
- keep the current line unparsed if it ends in CR and there's more data

This solves the issues #146 and #150 by ensuring that CRLF split by a
buffer boundary doesn't get treated as two row delimiters CR+LF
@doug-martin
v2.2.0
21791f4
@doug-martin doug-martin merged commit 5ac838e into master Sep 22, 2016
@doug-martin doug-martin deleted the v2.2.0 branch December 15, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doug-martin