Handle split CRLF #156
Closed
Handle split CRLF #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 21, 2016 18:00
- Add a test for issue C2FO#150 to specify the expected behavior - Mark it `skip` pending implementation
- Add a test for CRLF split between two buffers (a.k.a issue C2FO#150) to specify the expected behavior - Mark it `skip` pending implementation
- Modify existing tests for `\r` row delimiter to specify the behavior in case of CR vs.CRLF ambiguity issue C2FO#150 - Mark them `skip` pending implementation
doug-martin
approved these changes
Sep 22, 2016
Merged
|
Merged and will be published under v2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the parser's end of the buffer handling by keeping the line unparsed if the last token is
\rand there is more data.As a result, if the
\r\ntoken is split in half between two buffers it will be joined together in the processing of the second buffer.This solution is fully backward compatible and much simpler than auto-detection of a row delimiter, which also might be not fully backward compatible.
Fixes issues #150, #146