Skip to content

Commit

Permalink
fix: symbol-upload-linux fails if tmp dir doesn't exist (#128)
Browse files Browse the repository at this point in the history
* fix: symbol-upload-linux fails if tmp dir doesn't exist

* fix: signtool for github action runners

* fix: windows signature removal

Fixes #127
  • Loading branch information
bobbyg603 authored Jul 9, 2024
1 parent 0c1681a commit 63e37bc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions bin/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { ApiClient, BugSplatApiClient, OAuthClientCredentialsClient, VersionsApi
import commandLineArgs, { CommandLineOptions } from 'command-line-args';
import commandLineUsage from 'command-line-usage';
import { glob } from 'glob';
import { existsSync } from 'node:fs';
import { existsSync, mkdirSync } from 'node:fs';
import { mkdir, readFile, stat } from 'node:fs/promises';
import { basename, extname, join } from 'node:path';
import { basename, dirname, extname, join } from 'node:path';
import { importNodeDumpSyms } from '../src/preload';
import { safeRemoveTmp, tmpDir } from '../src/tmp';
import { uploadSymbolFiles } from '../src/upload';
Expand Down Expand Up @@ -114,6 +114,7 @@ import { CommandLineDefinition, argDefinitions, usageDefinitions } from './comma
symbolFilePaths = symbolFilePaths.map(file => {
console.log(`Dumping syms for ${file}...`);
const symFile = join(tmpDir, `${getSymFileBaseName(file)}.sym`);
mkdirSync(dirname(symFile), { recursive: true });
nodeDumpSyms(file, symFile);
return symFile;
});
Expand Down
4 changes: 2 additions & 2 deletions sea/windows.ps1
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
node --experimental-sea-config sea-config.json
node -e "require('fs').copyFileSync(process.execPath, '.\\dist\\symbol-upload-windows.exe')"
signtool remove /s .\dist\symbol-upload-windows.exe
$signtool = "C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\x64\signtool.exe"
& $signtool remove /s ".\dist\symbol-upload-windows.exe"
npx postject .\dist\symbol-upload-windows.exe NODE_SEA_BLOB .\dist\sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
#signtool sign /fd SHA256 symbol-upload-windows.exe

0 comments on commit 63e37bc

Please sign in to comment.