User column csv import error #14302
Merged
User column csv import error #14302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
changed the title
adrinr
requested review from
samwho and
mike12345567
and removed request for
a team
mike12345567
reviewed
Aug 2, 2024
| @@ -1849,6 +1851,202 @@ describe.each([ | |||
| const results = JSON.parse(res) | |||
| expect(results.length).toEqual(3) | |||
| }) | |||
|
|
|||
| describe("should allow exporting all column types", () => { | |||
There was a problem hiding this comment.
Very nice to have a proper test case for this!
mike12345567
approved these changes
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix importing user/users columns when exported as CSV. The current logic is handling CSV strings as JSON, but this is not true for our CSV exported objects. Adding some tests to check that the code works as expected.
The current export/import flow does:
/csvtojson/validateNewTableImportor/validateExistingTableImportBecause of this flow is highly dependent on the previous steps, we added a test that covers the full flow
Launchcontrol
Fix importing user/users data
Feature branch env
Feature Branch Link