Dont allow protected column names on import #14294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwho
approved these changes
Aug 2, 2024
|
|
||
| isInternal && | ||
| it.each( | ||
| isInternal ? PROTECTED_INTERNAL_COLUMNS : PROTECTED_EXTERNAL_COLUMNS |
There was a problem hiding this comment.
Is this needed? Doesn't the outer condition make this redundant?
There was a problem hiding this comment.
Amended here: #14302
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have some protected column names, such as _id and tableId, that can not be used in the schema. When exporting some csv we are exporting some of these columns, and when creating a new table via CSV upload allowed creating these columns as part of the schema.
This PR ensures that this is not the case, both on the API level and on the client side
Screen.Recording.2024-08-01.at.11.02.43.mov
Launchcontrol
Handle protected column names on table imports