-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic user relationship to user column migration #12102
Automatic user relationship to user column migration #12102
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #12102 +/- ##
==========================================
- Coverage 68.49% 67.20% -1.30%
==========================================
Files 594 502 -92
Lines 21984 19984 -2000
Branches 4424 4138 -286
==========================================
- Hits 15059 13430 -1629
+ Misses 6413 6068 -345
+ Partials 512 486 -26
... and 96 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…p-columns-to-the-new-user-column
…di-7607-migrate-user-relationship-columns-to-the-new-user-column
…the-new-user-column' of github.com:Budibase/budibase into feature/budi-7607-migrate-user-relationship-columns-to-the-new-user-column
…di-7607-migrate-user-relationship-columns-to-the-new-user-column
…di-7607-migrate-user-relationship-columns-to-the-new-user-column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall - just wanted to comment to say that really like the approach to the migration here - the column migrator is really nice way of handling this!
…the-new-user-column' into feature/budi-7607-migrate-user-relationship-columns-to-the-new-user-column-2
…rontend expects this to be set for every table so making the type represent this correctly.
…di-7607-migrate-user-relationship-columns-to-the-new-user-column
…the-new-user-column' into feature/budi-7607-migrate-user-relationship-columns-to-the-new-user-column-4
…r-relationship-columns-to-the-new-user-column-4 Frontend changes for the user column migration work.
…new sourceType which states what source the table came from, external or internal. Don't want to keep using a type that should be static as two different things.
…ternal or external table.
…r-relationship-columns-to-the-new-user-column-6 Replace several instances of `any` with `DatabaseQueryOpts`.
…required Make sourceId property of table required (for all table types)
…p-columns-to-the-new-user-column
…di-7607-migrate-user-relationship-columns-to-the-new-user-column
…p-columns-to-the-new-user-column
…p-columns-to-the-new-user-column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - massive improvement to typing included here!
Description
Feature branch for https://linear.app/budibase/issue/BUDI-7607/migrate-user-relationship-columns-to-the-new-user-column-type.
Addresses:
Documentation