Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace several instances of any with DatabaseQueryOpts. #12185

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Oct 26, 2023

This PR replaces any with DatabaseQueryOpts in a few places it was applicable to do so. The reason we were using any was because of a problem in @budibase/nano that was fixed in Budibase/couchdb-nano#1. With that in, we can make the typing around this better.

There are instances we can improve in budibase-pro, too, which I'll do in a follow-up PR over there.

@samwho samwho requested a review from mike12345567 October 26, 2023 14:54
@samwho samwho added the firestorm Data/Infra/Revenue Team label Oct 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #12185 (ae356b6) into feature/budi-7607-migrate-user-relationship-columns-to-the-new-user-column (9edaca0) will decrease coverage by 0.03%.
The diff coverage is 20.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                                              Coverage Diff                                               @@
##           feature/budi-7607-migrate-user-relationship-columns-to-the-new-user-column   #12185      +/-   ##
==============================================================================================================
- Coverage                                                                       67.16%   67.13%   -0.03%     
==============================================================================================================
  Files                                                                             502      502              
  Lines                                                                           19934    19939       +5     
  Branches                                                                         4125     4126       +1     
==============================================================================================================
- Hits                                                                            13388    13387       -1     
- Misses                                                                           6055     6064       +9     
+ Partials                                                                          491      488       -3     
Files Coverage Δ
packages/server/src/db/linkedRows/linkUtils.ts 82.81% <100.00%> (-1.57%) ⬇️
...rc/migrations/functions/backfill/global/configs.ts 100.00% <100.00%> (ø)
packages/backend-core/src/users/db.ts 8.41% <0.00%> (+0.03%) ⬆️
packages/server/src/sdk/app/links/links.ts 61.11% <50.00%> (ø)
packages/backend-core/src/users/users.ts 17.68% <25.00%> (-0.13%) ⬇️
packages/backend-core/src/docIds/params.ts 13.79% <0.00%> (-1.31%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@samwho samwho merged commit 731ff06 into feature/budi-7607-migrate-user-relationship-columns-to-the-new-user-column Oct 27, 2023
@samwho samwho deleted the feature/budi-7607-migrate-user-relationship-columns-to-the-new-user-column-6 branch October 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants