-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waterfox Current (and Firefox Quantum) cause loss of some types of legacy extension when used to open Waterfox Classic profiles #983
Comments
Works for me, and Stylus is functional. Did you download the 68.0a1 or build it yourself from latest gecko68 branch? If you downloaded it, how did you use the existing profile? Before trying v68, what Waterfox version did you last use with this profile? What version of Stylus do you have? |
I downloaded the binary, then ran it on a copy of a profile from 56.2.9.1. But I actually think the bug here is not what I thought. I saw a similar problem when doing an in-place upgrade from 56.2.9.1 to 56.2.10. After that upgrade, one of my addons (Prefbar) just "vanished" from the addons manager. I reinstalled it, and it worked again. Sure enough, if I re-installed Stylus from a local file, it started working fine. But there's still a weird bug in that the addon manager did NOT think it was there, but the addon page itself DID. |
Legacy? Which version? |
Stylus 1.5.3, which is a webextension. The addon that "disappeared" when going from 56.2.9 to 56.2.10 was PrefBar 7.1.1, which is a legacy addon. I can nuke the 68a profile, make a new copy, and try to reproduce it. |
|
The problem is likely "copying" the profile instead of using a profile in-place. This sounds like the same sort of issue I ran into in #947 before the profile location was fixed. If you want to use a copy of an existing Waterfox 56 profile with Waterfox 68, try this -
Does it work? |
Ah, but the upgrade of 56.2 was in place.
|
The issue you had with the in-place upgrade is likely unrelated to the issue involving Waterfox 68. |
I agree with that now - rather, I think it's the same issue in both cases, and is not specific to WF 68. (I just forgot to edit the issue title. Which, ironically, I can't do in Waterfox 56. :-) ) |
Not reproducible here. Would you like to raise a separate issue? Thanks. |
I am going to pull out a backup and see if I can reproduce it myself (will take me a couple of days). I just looked and found that a second extension disappeared in my 56.2.9 to 56.2.10 update. Would you prefer a separate issue altogether? (I just renamed that one, but can start over if you prefer.) |
Thanks,
For Waterfox Classic: yes please. The separation will help to focus this issue on Waterfox alpha. |
Ah. Will do - didn't realize separate projects.
- Keith
|
Meta, tracking: #538 Possible cross reference part of https://redd.it/deuzev for 68.0b2, in particular:
I don't plan to reinstall 68.0a1 but I imagine that an icon-free appearance might have been associated with |
This comment has been minimized.
This comment has been minimized.
Commentary at and under https://www.waterfox.net/blog/waterfox-2019.10-release-download/#commento-comment-card-e4f3a054c5e3445cc1683b02703516712b10c86a7e574fe66f441e8608a38e11 draws attention to losses that occur with this combination of applications:
A screen recording of this type of loss, using Waterfox Profile Manager:
The extension in this case:
Losses are silent and likely to cause annoyance so I suggest a bug label for this issue. Meta, tracking: #582 then #538 – first, document the bug; then aim to fix it. Related:
If we're to add anything like upgrade protection to Waterfox Current, it need not be as strict as (Firefox 67) downgrade protection. It should suffice to present a yellow alert ⚠ modal dialogue – with an option to quit – whenever a start of Waterfox Current detects Waterfox Classic profile content. Escape should quit. Modality in good time – before whatever will trigger the removal of this type of extension. |
PrefBar
caa:addon/prefbar Tested on Manjaro Linux with Waterfox Classic then Waterfox Current (2019.10). Using Waterfox Profile Manager. Added to Waterfox Classic 56.2.9, restart required. The extension was present and enabled following the restart. Quit. Started Waterfox Classic 56.2.10. The customary one-off check for compatibility did not result in removal of the extension. Quit. Started Waterfox Classic 2019.10 (20191023220600). The customary one-off check for compatibility did not result in removal of the extension. Quit. Started the same profile with Waterfox Current 2019.10. This removes the extension. |
This comment has been minimized.
This comment has been minimized.
There's uncertainty re: XUL overlay as a definition of what's affected. Unpacked extensionsArising from discussions in IRC:
A CRX Viewer view of source code for the CAA copy of PrefBar 7.1.1: Seeking From Removing Support for Unpacked Extensions | Mozilla Add-ons Blog (2018-08-22):
Related: I made removal of PrefBar, from the file system, reproducible with Firefox on FreeBSD. Terminal output below. |
⚠ CautionIn this case a symbolic link is used to share a single profile between Waterfox Classic and Firefox Quantum 70.⋯
|
With apologies for pinging re: obsolete technology … @mattbasta @muffinresearch #983 (comment) above Please, can either of you tell/guess what might cause automated removal of this type of extension from the file system? TIA |
I copied an existing profile and started up the 68a1 release. One of the extensions already installed was Stylus. It's not functional (no surprise), but if I open the addons manager, it does not appear there. However, if I go to AMO and open up the page for the addon, it thinks it is there and only offer me a button to Remove it. So something in the browser thinks it's there, just not the addons page.
The text was updated successfully, but these errors were encountered: