Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of Waterfox Current should not default to upgrade Waterfox Classic #1189

Closed
grahamperrin opened this issue Oct 12, 2019 · 3 comments

Comments

@grahamperrin
Copy link

With the installer for 68.0b1 on Windows, where (a) Waterfox Classic is installed and (b) the user has admin privileges (i.e. can overwrite Classic):

  • the word Upgrade is visible during the default installation routine.

However:

  • some users will overlook the word
  • some users will see the word but not realise the implications.

Upgrade is too risky a default.

Assume that if the user has Waterfox Classic, the user will want to retain Waterfox Classic (alongside Waterfox Current).

Windows

A fix might involve defaulting to a different directory e.g.

C:\Program Files\Waterfox Current

If the signed in user lacks privileges to write to the above path, then e.g.

%APPDATA%\Local\Waterfox Current

– compare with the 68.0b1 default:

image

image

Linux

Mac OS X

Is it possible to have drag-and-drop installation of a distinctively-named bundle e.g.

Waterfox Current.app

– with the generic, non-distinctive name Waterfox for the running application?

Maybe possible, but from an accessibility perspective I don't like the idea.

Related

Meta, tracking: #538

#983

#1152

#1142 – if an unwanted upgrade occurs, then the Waterfox Current first run UX may be poor.

@hawkeye116477
Copy link
Contributor

hawkeye116477 commented Oct 12, 2019

Maybe just change in mozconfig => ac_add_options --with-app-name=waterfox to ac_add_options --with-app-name=waterfox-current.

@MrAlex94
Copy link
Collaborator

MrAlex94 commented Oct 15, 2019

This change already fixes this, as this is what the installer code references for which path to use.

@grahamperrin
Copy link
Author

Fix confirmed, thanks.

Quick test routine (on Windows 10):

  1. uninstall Waterfox Current 68.0b1
  2. uninstall Waterfox Classic 56.2.14
  3. install and run Waterfox Classic 2019.10
  4. install and run Waterfox Current 2019.10

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants