Fixed enhancement issue for puzzle cell classes extending from GridCe… #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll as Integer types to respective types for Masyu, Nurikabe, Skyscrapers, and TreeTent puzzles.
Changed Legup to LEGUP in README.
|
Please mark down the Type of Change and any actions you have fulfilled in the Checklist in your original Pull Request. |
Corppet
reviewed
Feb 14, 2023
| @@ -34,10 +34,10 @@ The LEGUP interface allows the user to solve different types of grid-based logic | |||
|
|
|||
| So, how does the LEGUP interface differ from online platforms for grid-based games? The most important difference is that the LEGUP interface requires the user to explicitly indicate their logical reasoning. Thus, solving the puzzle due to some lucky guesses is no longer an option! The interface will congratulate the user less on the fact that the user was able to solve the puzzle, but more on how the user solved the puzzle. This is essential to logic. Logic is not about the truth or the correct or best answer, but about deductive implication and valid inference. What follows from what, and why? | |||
|
|
|||
| LEGUP also provides a single interface that is capable of supporting many different types of puzzles. Since most of the interface remains the same, however, users wil start to recognize certain similarities between the different puzzles. In particular, since they have to explicitly state their reasoning, users should start to see strong similarities in their logical reasoning patterns from puzzle to puzzle, is the very basis of the abstract logical reasoning principles taught in traditional logic courses. However, rather than being "thrown in the water" with abstract principles based on obscure symbols, users instead are dealing with a concrete, fun, and engaging logic puzzle. As such, LEGUP aims to give its users a "leg up" when it comes to the understanding of logic. | |||
| LEGUP also provides a single interface that is capable of supporting many different types of puzzles. Since most of the interface remains the same, however, users wil start to recognize certain similarities between the different puzzles. In particular, since they have to explicitly state their reasoning, users should start to see strong similarities in their logical reasoning patterns from puzzle to puzzle, is the very basis of the abstract logical reasoning principles taught in traditional logic courses. However, rather than being "thrown in the water" with abstract principles based on obscure symbols, users instead are dealing with a concrete, fun, and engaging logic puzzle. As such, Legup aims to give its users a "leg up" when it comes to the understanding of logic. | |||
There was a problem hiding this comment.
"LEGUP" should be in all caps. Please do not include changes that do not relate to the pull request.
|
Please make sure your changes do not cause compiler errors. Simply changing the extended type in the |
|
I removed the flag name change, since that would best be done in a separate pull request on a separate branch. Additionally, those changes also require you to change how the Short Truth Table importer reads the files. |
|
Closing this pull request because no changes have been made for the past two weeks and current changes have failed both checks. Please make a new pull request if you want to add further changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll as Integer types to respective types for Masyu, Nurikabe, Skyscrapers, and TreeTent puzzles.
Description
Changed puzzle cell classes extending from GridCell to the specific puzzle type. Issue #139
Closes #(issue)
Type of change
How Has This Been Tested?
Checklist: