Puzzle Cell classes extend from GridCell as an integer

[Corppet]

All puzzles currently have their cell class extend from GridCell as Integer types, yet they have their own respective types/enums. It may be a good idea down the line to change each cell class to use their own respective classes instead, which also means changing GridCell and PuzzleElement to work with enums.

For Example:

Current:

public class TreeTentCell extends GridCell<Integer>

Suggestion:

public class TreeTentCell extends GridCell<TreeTentType>

To do:

• Revise the GridCell and PuzzleElement classes to work with enums. If the codebase seems more suitable to use Integer instead of their respective types, please comment about it below and provide some short reasoning if you can. Alternatively, you can store the integer data value within the enum class instead of GridCell and have your code perform arithmetic on that instead.

Change the cast types for each cell class...

• Battleship
• Fillapix
• Heyawake
• Lightup
• Masyu
• Nurikabe
• Short Truth Table
• Skyscrapers
• Sudoku
• Tree Tent

[charlestian23]

Note that if any changes are made here, we should double check that this tutorial is still up to date: https://github.com/Bram-Hub/Legup/wiki/Implementing-Puzzles

[25tallurich]

Im doing LightUp rn

[ErinCohenGH]

I can do Nurikabe

[Acewvrs]

For Sudoku, you'd actually want to use integer types. I'll now do SkyScrapers.

-- update: finished Skyscrapers and waiting for the PR review

[pitbull51067]

I'll do Fillapix

[RyancRiv]

I can do Skyscrapers

[ErinCohenGH]

I believe someone is already doing both of those

[Acewvrs]

heyawake doesn't have its custom types, so I think using integers is fine here too. I'll do masyu now

-- update: finished masyu. updated to the PR

[pitbull51067]

I'll do Tree Tent

[Corppet]

I have already talked with some of you, but if you think the puzzle you are working on is using arithmetic with the data property in their respective GridCell and you think the generic type of the cell is better left as an Integer, please indicate so in a comment and provide some simple reason as to why.

[ErinCohenGH]

Nurikabe is also better left as an Integer because setting the type of cell is reliant on being able to set a numerical value in addition to just black or white.

[ErinCohenGH]

Is LightUp still being worked on?

[25tallurich]

LightUp has the same issue as heyawake and Sudoku the code does math on the numbers so it is not viable to do.

[ErinCohenGH]

I'll do Short Truth Table then, thanks.