Puzzle Editor Major Changes #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed class to keep naming consistent
Puzzle editor
added menu bars, mostly non-functional, but file>new opens up the file dialog
Puzzle editor draft of basic PuzzleEditorPanel
Saving some changes
Adjusted font
for the puzzle editor panel
Puzzle editor now has framework to add element buttons
Resized some buttons and moved batch grader button
running into some issues with swing
made more progress on Puzzle editor window
Add puzzle creator dialog
Puzzle editor exit button
…ng an empty sudoku puzzle
New abstract method in Puzzle class meant to be used to check if a puzzle is a valid size
Renamed width and height variables to rows and columns for clarity purposes
Implemented general empty puzzle functionality and started with sudoku
Update branch
Did this for clarity and to be consistent throughout the code. Note that I did not go through and change all the comments in all the importers.
Implemented isValidDimensions()
- Fixed null panel bug when opening apuzzle for the first time - Fixed a bug where puzzle editor panel wouldn't clear properly after entering invalid dimensions - Fixed the title not changing on the home screen after returning from the puzzle editor
Fixed some bad coding style
Changed the placeholder code to be throwing an exception instead of returning false
Requires the number of rows and columns to be greater than 1 for Sudoku
charlestian23
added
priority
…imensions Puzzle Editor Dimension Validation
|
All done, goto #193 |
Resolve puzzle-editor merge conflicts
mattsweet417
approved these changes
Jul 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of a puzzle editor has massively changed how we structure a lot of Legup. While we are not done implementing a puzzle editor, we realized that future updates to Legup should take into account the new structure we implemented, as resolving merge conflicts with this new structure is incredibly painful.