Puzzle Editor Dimension Validation #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New abstract method in Puzzle class meant to be used to check if a puzzle is a valid size
Renamed width and height variables to rows and columns for clarity purposes
Update branch
Did this for clarity and to be consistent throughout the code. Note that I did not go through and change all the comments in all the importers.
Implemented isValidDimensions()
- Fixed null panel bug when opening apuzzle for the first time - Fixed a bug where puzzle editor panel wouldn't clear properly after entering invalid dimensions - Fixed the title not changing on the home screen after returning from the puzzle editor
charlestian23
added
puzzle editor
Fixed some bad coding style
Changed the placeholder code to be throwing an exception instead of returning false
Requires the number of rows and columns to be greater than 1 for Sudoku
mattsweet417
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legup will now show an error message if the number of rows and columns entered is invalid. Note that functionality only works for Sudoku since I didn't implement
isValidDimensionsfor any other puzzles (I'll do that later separately).This implementation is also kind of slow, so I want to increase the speed before we push this to
dev. I'm just opening a pull request for now because it at least functionally works.