Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkdownEditor and MarkdownSplitEditor always wrap lines #3150

Merged
merged 1 commit into from
Jul 25, 2019
Merged

MarkdownEditor and MarkdownSplitEditor always wrap lines #3150

merged 1 commit into from
Jul 25, 2019

Conversation

amedora
Copy link
Contributor

@amedora amedora commented Jul 25, 2019

Description

Before #3063 has merged, MarkdownEditor and MakrdownSplitEditor use CodeMirror always with 'lineWrapping' is on. #3063 has changed that behavior, so bring it back.

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@Rokt33r Rokt33r added this to the v0.12.1 milestone Jul 25, 2019
@Rokt33r Rokt33r merged commit 71d27d0 into BoostIO:master Jul 25, 2019
@sriharshachilakapati
Copy link

Thanks for the work @amedora!

@amedora amedora deleted the fix-3145-linewrapping branch July 30, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants