Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2892: Line wrapping #3063

Merged
merged 5 commits into from
Jul 22, 2019
Merged

Fix 2892: Line wrapping #3063

merged 5 commits into from
Jul 22, 2019

Conversation

amedora
Copy link
Contributor

@amedora amedora commented Jun 6, 2019 •
edited
Loading

Description

wrapline
preference

Issue fixed

#2892

TODO

  • Add new locale strings

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 9, 2019
@amedora amedora changed the title [WIP] Fix 2892: Line wrapping Fix 2892: Line wrapping Jun 11, 2019
ZeroX-DG
ZeroX-DG approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jul 20, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r July 20, 2019 00:40
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Jul 22, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 22, 2019
@Rokt33r Rokt33r merged commit c83e5cc into BoostIO:master Jul 22, 2019
This was referenced Jul 23, 2019
Open
Closed
@Flexo013
Copy link
Contributor

This PR most likely removed line wrapping from Markdown notes.

@Flexo013 Flexo013 mentioned this pull request Jul 24, 2019
Closed
@amedora amedora mentioned this pull request Jul 25, 2019
Merged
@amedora amedora deleted the fix-2892-wrapline branch July 30, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@amedora @Flexo013 @ZeroX-DG @Rokt33r