Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration validation email missing baseUrl. #218

Closed
ghost opened this issue Oct 28, 2016 · 2 comments
Closed

Registration validation email missing baseUrl. #218

ghost opened this issue Oct 28, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 28, 2016

PHP Version:

> php --version;
PHP 5.6.27-0+deb8u1 (cli) (built: Oct 15 2016 15:53:28) 
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies

MySQL Version:

I was unable to install MySQL >= 5.6 on Debian Jessie, so I installed MariaDB:

> mysql --version;
mysql  Ver 15.1 Distrib 10.0.27-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2

Expected Behavior:

When registering a new account, and the email address validation email is sent, it should contain the baseUrl() value in the links to that they are clickable.

Actual Behavior:

EMail was received, but it contained 'dead' links. Changing the email view to 'Plain Text' displayed this:

Email Confirmation

Thanks for joining Some Domain </>.
Please confirm your email address by clicking the button below.

Confirm Email </register/confirm/SubxIprQpCHyZJBNgkdn8ix2>

Note there is no "http://www.SomeDomain.com" prefix. As such, the link is not clickable.

@ssddanbrown
Copy link
Member

@edykstra Thanks for reporting, Good spot. I'll get a bugfix release out over the weekend to cover this and a few other minor bugs.

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.12.2 milestone Oct 30, 2016
ssddanbrown added a commit that referenced this issue Oct 30, 2016
Also added links to sign-in/register.
Fixed links in emails sent out.

Fixes #210 and #218.
@ssddanbrown
Copy link
Member

Thank you for finding this issue. It is now fixed as of release v0.12.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant