Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements to Reset Password page #210

Closed
AbijeetP opened this issue Oct 21, 2016 · 4 comments
Closed

UI Improvements to Reset Password page #210

AbijeetP opened this issue Oct 21, 2016 · 4 comments

Comments

@AbijeetP
Copy link
Contributor

For Feature Requests

Desired Feature: UI Improvements to Reset Password page

For Bug Reports

PHP Version: PHP 5.6.24-0+deb8u1

MySQL Version: MariaDB 10.0.x

Expected Behavior:

  1. No confirmation of ending of process.
  2. No link back to login page.

Actual Behavior:

  1. Reset Password confirmation - Clicking on Send Reset Link causes the page to submit, but no confirmation is displayed to the user informing that a mail was sent or that the processing has ended.
  2. Needs a link back to the login page.
@ssddanbrown ssddanbrown added this to the BookStack Beta v0.12.2 milestone Oct 30, 2016
ssddanbrown added a commit that referenced this issue Oct 30, 2016
Also added links to sign-in/register.
Fixed links in emails sent out.

Fixes #210 and #218.
@ssddanbrown
Copy link
Member

Thank you for finding this issue. It is now fixed as of release v0.12.2.

@Abijeet
Copy link
Member

Abijeet commented Oct 30, 2016

@ssddanbrown - Testing this on demo leads me to an error on clicking on Send Reset Link.

@ssddanbrown
Copy link
Member

@Abijeet On demo.bookstackapp.com? If so then yeah, I hadn't configured the emails sends properly. 😱 Now set to just log upon mail so should not error.

@Abijeet
Copy link
Member

Abijeet commented Oct 30, 2016

@ssddanbrown - Yup on demo.bookstackapp.com. Only logging makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants