add a significant patch about manifest separating #17
Conversation
remove useless main.js
because inside `findMatchingBucket`, all the `userRequest` manipulation are just for retrieve the path as `resource`
1. move the bucketChunks management out of the entry chunk loop which makes more sense. 2. create a manifest chunk to act as the only entry chunk. see discussion in BohdanTkachenko#7 ps: improve example's html script entries
|
@BohdanTkachenko , could you review this pr 😃 |
|
Wow! Looks great! Will review it. |
|
It seems that this PR breaks html-webpack-plugin. |
|
@BohdanTkachenko , could you provide some example code to test? And, analyzing from your error above, it seems that ejs file is not converted to hml string before being passed to the html-webpack-plugin. Coud you add something like ejs-loader or so? |
|
You can find an example here: https://github.com/BohdanTkachenko/webpack-split-by-path-error-demo-1 Also, I changed from ejs to html and it is the same. Also if you switch to master branch of webpack-split-by-path - everything works. |
if not doing so, other plugins like `html-webpack-plugin` will crash as we extract its inner chunks's modules' dependencies outside.
As Html-webpack-plugin runs a child compiler, which initiated with part of parent compiler's plugins by webpack. If we listen on `compilation`, handlers in `webpack-split-by-path` will be copy to the child compilation instance, which cases some unwanted extraction. So, we just listen to `this-compilation`. See https://github.com/webpack/webpack/blob/webpack-1/lib/Compiler.js#L327-L328 and https://github.com/webpack/webpack/blob/webpack-1/lib/Compiler.js#L363-L364
|
@BohdanTkachenko i just solved the problem with some changes. It may break compatibility. The reason that the master doesn't have problem, is that it doesn't add a chunk outside chunk filtering logic which doesn't impact the child compilation with just skipping. |
|
@BohdanTkachenko, do you have time to review? |
|
Tested - seems to be working. Merged and published to NPM as version 0.1.0 |
|
it is normal that user might use multiple instance of Webpack-split-by-path? Current implementation doesn't support multiple instance as manifest is the only entry chunk that the non-first instances actually do nothing. |
|
I don't think that it is normal because webpack-split-by-path supports several bundles in configuration, so no need in several instances of a plugin. |
this is a big PR!