Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work well with html-webpack-plugin #8

Closed
sheerun opened this issue Nov 28, 2015 · 4 comments
Closed

Doesn't work well with html-webpack-plugin #8

sheerun opened this issue Nov 28, 2015 · 4 comments

Comments

@sheerun
Copy link
Contributor

sheerun commented Nov 28, 2015

If I use your default example with html-webpack-plugin (you can use code on https://github.com/sheerun/webpack-split), then only vendor script is included..

This plugin seems to work well with common chunks plugin.

Also see: jantimon/html-webpack-plugin#127

@GreenGremlin
Copy link

Adding css-loader to the ignore option fixed this, for me.

    new SplitByPathPlugin(
      [{ name: 'vendor', path: __dirname + '/node_modules' }],
      { ignore: [__dirname + '/node_modules/css-loader'] }
    ),

@GreenGremlin
Copy link

I've also added style-loader and css to the ignore list.

ignore: [
  __dirname + '/node_modules/css-loader',
  __dirname + '/node_modules/style-loader',
  /\.css/
]

@e-cloud
Copy link
Contributor

e-cloud commented Mar 17, 2016

@GreenGremlin, to a certain extent , it works.

@BohdanTkachenko
Copy link
Owner

Is this issue still occurs? After PR #17 everything seems to work perfect with html-webpack-plugin. Please re-open this issue if you still have problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants