Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modular equations #131

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Modular equations #131

merged 2 commits into from
Aug 28, 2018

Conversation

Bodigrim
Copy link
Owner

Closes #129.

@rockbmb @b-mehta please review.

rockbmb
rockbmb approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@rockbmb rockbmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, missing benchmarks but it is not clear to me how to do that.

b-mehta
b-mehta approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Bodigrim Bodigrim merged commit a7e7ead into Bodigrim:master Aug 28, 2018
@Bodigrim Bodigrim deleted the equations branch August 28, 2018 20:36
@rockbmb rockbmb mentioned this pull request Aug 28, 2018
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-mehta b-mehta b-mehta approved these changes

@rockbmb rockbmb rockbmb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bodigrim @rockbmb @b-mehta