Wrong ROI coordinates for new Fluidigm software versions

[jwindhager]

imctools version: 2.1.0
Python version: 3.9.1
Operating System: Ubuntu 20.04.1 LTS

The ROI coordinate fix is only applied to old Fluidigm software versions:

imctools/imctools/io/mcd/mcdxmlparser.py

Lines 115 to 120 in c7238b7

	# TODO: check if the issue is fixed in newer Fluidigm versions
	roi_start_x_pos_um = float(a.get(const.ROI_START_X_POS_UM, 0))
	roi_start_y_pos_um = float(a.get(const.ROI_START_Y_POS_UM, 0))
	if slide.sw_version is None or version.parse(slide.sw_version) <= version.parse("7.0.5189.0"):
	roi_start_x_pos_um /= 1000
	roi_start_y_pos_um /= 1000

The code doesn't work correctly for current Fluidigm software versions. This isn't future-proof and a fix is urgently needed.

[plankter]

Which slide.sw_version do you have in affected files? We don't have any specification updates from Fluidigm and this 1000 bug-fix was discovered by Vito, as I remember.

[plankter]

This is an issue we had back then: Correct Fluidigm's comma fault #72

[plankter]

I see two options: either I remove version check completely (then we may have problems with future fixed versions), or I update the version number to the latest known version, which is broken.

[plankter]

Fixed in 2.1.3