Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROIs and panaorama don't seem to match #4

Closed
nilseling opened this issue Jan 20, 2021 · 5 comments
Closed

ROIs and panaorama don't seem to match #4

nilseling opened this issue Jan 20, 2021 · 5 comments
Assignees
@jwindhager
Labels
bug Something isn't working

Comments

@nilseling
Copy link

Hey, I checked a couple of .mcds and in none of them the ROIs overlay with the panorama - I will give you the .mcds for testing. This was tested on macOS 10.15.17 using the napari-imc conda environment running napari-imc v0.1.0.
@jwindhager
Copy link
Contributor

Thank you for reporting this, @nilseling! I will look into it. Is this concerning user-uploaded panorama images (i.e., image files that the user manually adds to the mcd) or ROI panoramas generated by the machine?

@jwindhager jwindhager added the bug Something isn't working label Jan 20, 2021
@jwindhager jwindhager self-assigned this Jan 20, 2021
@nilseling
Copy link
Author

I was talking about the machine generated panorama ROIs. Sorry for not being specific

@jwindhager
Copy link
Contributor

This is due to BodenmillerGroup/imctools#104

@jwindhager
Copy link
Contributor

Closed accidentally, reopening

@jwindhager jwindhager reopened this Jan 20, 2021
@jwindhager
Copy link
Contributor

jwindhager commented Jan 21, 2021 •
edited
Loading

Fixed with imctools v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwindhager jwindhager

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwindhager @nilseling