Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace amp_cv with relative_skew #59

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Replace amp_cv with relative_skew #59

merged 1 commit into from
Jul 17, 2024

Conversation

seirios
Copy link
Contributor

@seirios seirios commented Jul 9, 2024

Update spec consistent with BlueBrain/neurodamus#180

@seirios seirios requested a review from WeinaJi July 9, 2024 11:44
@WeinaJi
Copy link
Contributor

WeinaJi commented Jul 16, 2024

LGTM!
@darshanmandge , do you use amp_cv in BlueCelluLab? If yes, please note this coming change.

@darshanmandge
Copy link

Thanks @WeinaJi . Yes we do have amp_cv in BlueCelluLab. We will replace it with relative_skew.

@WeinaJi
Copy link
Contributor

WeinaJi commented Jul 16, 2024

Thanks @WeinaJi . Yes we do have amp_cv in BlueCelluLab. We will replace it with relative_skew.

Great! Then I will change the libsonata API corresponding to this new parameter.

@WeinaJi WeinaJi mentioned this pull request Jul 16, 2024
Merged
@WeinaJi WeinaJi merged commit 3d8c870 into BlueBrain:master Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeinaJi WeinaJi WeinaJi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seirios @WeinaJi @darshanmandge