Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute/RelativeShotNoise input: replace amp_cv with relative_skew #361

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Absolute/RelativeShotNoise input: replace amp_cv with relative_skew #361

merged 6 commits into from
Jul 17, 2024

Conversation

WeinaJi
Copy link
Collaborator

@WeinaJi WeinaJi commented Jul 16, 2024 •
edited
Loading

@WeinaJi WeinaJi marked this pull request as ready for review July 16, 2024 15:58
darshanmandge
darshanmandge approved these changes Jul 17, 2024
View reviewed changes
Copy link

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This change looks good to the Cells team.

@WeinaJi
Copy link
Collaborator Author

WeinaJi commented Jul 17, 2024

Thanks. This change looks good to the Cells team.

@darshanmandge Thank you for the review. I have also updated the simulation parser in the previous two PRs that I forgot to inform you.
#359
#358
Once a new tag is created and deployed on bb5, you will probably see the difference on your side.

@darshanmandge
Copy link

@WeinaJi Thanks for informing about these changes! We will update bluecellulab accordingly.

@WeinaJi WeinaJi merged commit 8571583 into master Jul 17, 2024
24 checks passed
@WeinaJi WeinaJi deleted the weji/relative_skew branch July 17, 2024 14:58
@ilkilic
Copy link

ilkilic commented Jul 19, 2024

I can confirm that #359 #358 do not affect bluecellulab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorblancoa jorblancoa jorblancoa approved these changes

@darshanmandge darshanmandge darshanmandge approved these changes

@seirios seirios Awaiting requested review from seirios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WeinaJi @darshanmandge @ilkilic @jorblancoa