-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor functions that include running isolated simulations [vcs: #minor] #149
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 89.57% 90.86% +1.28%
==========================================
Files 87 89 +2
Lines 5403 5320 -83
==========================================
- Hits 4840 4834 -6
+ Misses 563 486 -77 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! looks good to me
Description
RNGSettings is not Cell or Synapse dependent. It is NEURON dependent.
This PR removes the RNGSettings dependency in Cell and Synapse. It also creates the IsolatedProcess to consistently handle the scenarios require running NEURON in isolation. Removing RNGSettings helps there since now there is one less parameter to pass to the subprocess.
Changes