Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor functions that include running isolated simulations [vcs: #minor] #149

Merged
merged 37 commits into from
Mar 14, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Mar 8, 2024

Description

RNGSettings is not Cell or Synapse dependent. It is NEURON dependent.
This PR removes the RNGSettings dependency in Cell and Synapse. It also creates the IsolatedProcess to consistently handle the scenarios require running NEURON in isolation. Removing RNGSettings helps there since now there is one less parameter to pass to the subprocess.

Changes

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 93.24324% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 90.86%. Comparing base (eb63577) to head (b629e38).

Files Patch % Lines
bluecellulab/cell/core.py 61.90% 8 Missing ⚠️
bluecellulab/synapse/synapse_types.py 62.50% 6 Missing ⚠️
bluecellulab/utils.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   89.57%   90.86%   +1.28%     
==========================================
  Files          87       89       +2     
  Lines        5403     5320      -83     
==========================================
- Hits         4840     4834       -6     
+ Misses        563      486      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilbey anilbey marked this pull request as ready for review March 13, 2024 14:24
@anilbey anilbey changed the title Refactor functions that include running isolated simulations Refactor functions that include running isolated simulations [vcs: #minor] Mar 13, 2024
Copy link
Contributor

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! looks good to me

@anilbey anilbey merged commit 8bfa9b5 into main Mar 14, 2024
10 checks passed
@anilbey anilbey deleted the isolations branch March 14, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants