Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify RNGSettings logic for setting the seeds #87

Closed
anilbey opened this issue Sep 29, 2023 · 1 comment
Closed

simplify RNGSettings logic for setting the seeds #87

anilbey opened this issue Sep 29, 2023 · 1 comment

Comments

@anilbey
Copy link
Contributor

anilbey commented Sep 29, 2023

Currently, Synapse objects are doing redundant work on checking and assigning RNGSettings values. See if the RNGSettings checking and assigning can be moved to the Simulator.

        if cell.rng_settings is None:
            self.rng_setting = bluecellulab.RNGSettings(
                mode='Compatibility',
                base_seed=base_seed)
        elif base_seed is not None:
            raise Exception('Synapse: base_seed and RNGSettings cant '
                            'be used together')
        else:
            self.rng_settings = cell.rng_settings
@anilbey
Copy link
Contributor Author

anilbey commented Mar 14, 2024

This is fixed. With #149 neither Synapse not Cell store an rng_settings object as an attribute.

@anilbey anilbey closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant