Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network_parameters: change bip21 schema liquidtestnet->liquidnetwork #206

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RCasatta
Copy link
Contributor

The bip21 schema doesn't need to convey the network, indeed for bitcoin we have only bitcoin: as schema for every network (mainnet, testnet, signet, regtest)

This is indeed a breaking change and the liquidtesnet schema is used in the wild, however, since it's breaking only for testnet networks, I think it makes sense to change it.

@angelix @lvaccaro @LeoComandini @jgriffiths @jkauffman1 @domegabri @whitslack @alessandro-saglimbeni

related ElementsProject/elements#805

the schema doesn't need to convey the network, indeed for bitcoin we
have only `bitcoin:` as schema for every network (mainnet, testnet,
signet, regtest)

This is indeed a breaking change and the liquidtesnet schema is used in
the wild, however, since it's breaking only for testnet networks, it
makes sense to change it.
@LeoComandini
Copy link
Contributor

ACK 71937f6

I would add a changelog entry though.

@whitslack
Copy link

Concept NAK. Bitcoin's overloading of the bitcoin: scheme is arguably a design oversight with real drawbacks for users. Consider that quite often wallet software will come packaged as separate apps for mainnet and testnet implementations. Then, users are forced either to avoid setting a default handler for BIP21 URIs (and thus always needing to choose a handling app every time they invoke a URI) or to choose a default app and lose the ability to invoke URIs intended for other networks. Using distinct URI schemes allows each network to have an appropriate app configured to handle its own relevant URIs.

@LeoComandini
Copy link
Contributor

ACK 381f03c, we should do the same as bitcoin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants