Skip to content

Commit

Permalink
network_parameters: change bip21 schema liquidtestnet->liquidnetwork
Browse files Browse the repository at this point in the history
the schema doesn't need to convey the network, indeed for bitcoin we
have only `bitcoin:` as schema for every network (mainnet, testnet,
signet, regtest)

This is indeed a breaking change and the liquidtesnet schema is used in
the wild, however, since it's breaking only for testnet networks, it
makes sense to change it.
  • Loading branch information
RCasatta committed Apr 24, 2024
1 parent f2963b2 commit 71937f6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/source/examples/get_networks.json
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
"asset_registry_onion_url": "http://lhquhzzpzg5tyymcqep24fynpzzqqg3m3rlh7ascnw5cpqsro35bfxyd.onion/testnet/",
"asset_registry_url": "https://assets-testnet.blockstream.info/",
"bech32_prefix": "tex",
"bip21_prefix": "liquidtestnet",
"bip21_prefix": "liquidnetwork",
"blech32_prefix": "tlq",
"blinded_prefix": 23,
"blob_server_onion_url": "",
Expand Down Expand Up @@ -480,7 +480,7 @@
"asset_registry_onion_url": "http://lhquhzzpzg5tyymcqep24fynpzzqqg3m3rlh7ascnw5cpqsro35bfxyd.onion/testnet/",
"asset_registry_url": "https://assets-testnet.blockstream.info/",
"bech32_prefix": "tex",
"bip21_prefix": "liquidtestnet",
"bip21_prefix": "liquidnetwork",
"blech32_prefix": "tlq",
"blinded_prefix": 23,
"blob_server_onion_url": "",
Expand Down
4 changes: 2 additions & 2 deletions src/network_parameters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ static std::map<std::string, std::shared_ptr<nlohmann::json>> registered_network
{ "asset_registry_onion_url", "http://lhquhzzpzg5tyymcqep24fynpzzqqg3m3rlh7ascnw5cpqsro35bfxyd.onion/testnet/" },
{ "asset_registry_url", "https://assets-testnet.blockstream.info/" },
{ "bech32_prefix", "tex" },
{ "bip21_prefix", "liquidtestnet" },
{ "bip21_prefix", "liquidnetwork" },
{ "blech32_prefix", "tlq" },
{ "blinded_prefix", 23u },
{ "blob_server_url", std::string() },
Expand Down Expand Up @@ -602,7 +602,7 @@ static std::map<std::string, std::shared_ptr<nlohmann::json>> registered_network
{ "asset_registry_onion_url", "http://lhquhzzpzg5tyymcqep24fynpzzqqg3m3rlh7ascnw5cpqsro35bfxyd.onion/testnet/" },
{ "asset_registry_url", "https://assets-testnet.blockstream.info/" },
{ "bech32_prefix", "tex" },
{ "bip21_prefix", "liquidtestnet" },
{ "bip21_prefix", "liquidnetwork" },
{ "blech32_prefix", "tlq" },
{ "blinded_prefix", 23u },
{ "blob_server_url", std::string() },
Expand Down

0 comments on commit 71937f6

Please sign in to comment.