Fix optional time_limit access in create of question sets #11 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional time_limit value was not provided access by PHP. Add test to verify access to time_limit. Add test to confirm expired response. Bump to v4.0.3
|
@alain ready for review and packaging when green |
| { | ||
| $person = self::createTestPerson(); | ||
| $qs = $person->question_sets->create(2); | ||
| sleep(4); |
There was a problem hiding this comment.
This sleep is necessary right?
There was a problem hiding this comment.
Yes - we are proving that a short time limit expires and the client receives the expired flag properly set as NOW expired. I made it short, but it still adds briefly to the test run. But it confirms that it is returned AND it is accessible to the client code.
|
As long as the sleep is required, this LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional time_limit value was not provided access by PHP.
Add test to verify access to time_limit.
Add test to confirm expired response.
Bump to v4.0.3