Merge pull request #14 from BlockScore/fix/add_optional_time_limit

Fix optional time_limit access in create of question sets #11

VERSION

@@ -1 +1 @@
-4.0.2
+4.0.3

lib/ApiResource.php

@@ -159,12 +159,14 @@ protected function _search()
     }
 
     /**
+     * @param Integer $time_limit seconds before question set expires.
+     *
      * @return QuestionSet The created QuestionSet.
      */
-    protected function _createQuestionSet()
+    protected function _createQuestionSet($time_limit)
     {
         $url = static::classUrl();
-        $params = array('person_id' => $this->id);
+        $params = array('person_id' => $this->id, 'time_limit' => $time_limit);
         $response = static::_makeRequest('post', $url, $params);
         $qs_obj = Util\Util::convertToBlockScoreObject($response);
         $this->addExisting($qs_obj);

lib/QuestionSet.php

@@ -18,11 +18,13 @@ public function __construct($id)
     }
 
     /**
+     * @param Integer $time_limit seconds before question set expires.
+     *
      * @return QuestionSet The created QuestionSet.
      */
-    public function create()
+    public function create($time_limit = 0)
     {
-        return self::_createQuestionSet();
+        return self::_createQuestionSet($time_limit);
     }
 
     /**

tests/QuestionSetTest.php

@@ -35,6 +35,24 @@ public function testCreateQuestionSet()
         }
     }
 
+    public function testCreateQuestionSetWithTimeLimit()
+    {
+        $person = self::createTestPerson();
+        $qs = $person->question_sets->create(17);
+
+        $this->assertSame($qs->time_limit, 17);
+    }
+
+    public function testTimeLimitExpired()
+    {
+        $person = self::createTestPerson();
+        $qs = $person->question_sets->create(2);
+        sleep(4);
+
+        $retrieved_qs = $person->question_sets->retrieve($qs->id);
+        $this->assertSame($retrieved_qs->expired, true);
+    }
+
     public function testAllQuestionSet()
     {
         $person = self::createTestPerson();