Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Signature #29

Merged
merged 4 commits into from
May 7, 2024
Merged

Extract Signature #29

merged 4 commits into from
May 7, 2024

Conversation

bh2smith
Copy link
Collaborator

@bh2smith bh2smith commented May 5, 2024

Introducing Type Interface for TxStatus and a function to extract signatures with a unit test. Here is an example response from the RPC.

Special Notes

  1. It is very strange to have to define types for RPC call responses. There should be a library maintaining these types... like near-rpc or something.
  2. The near docs do not specify a type for this response data (merely an example response with empty arrays in the any fields). However, QuickNode does provide some vague documentation about these types (but their example still returns an empty array -- i.e. not enough to declare types). This issue is captured in a TODO comment (see inline changes), but does not affect the functionality of our code (cf passing CI).
  3. The test introduced here is more of an integration test than a unit test (because it does call the testnet rpc).

cc @SurgeCode

⚠️ I HAVE TEMPORARILY DISABLED E2E tests in CI (because MPC Contract is currently not functional) ⚠️

@bh2smith bh2smith marked this pull request as ready for review May 7, 2024 12:12
@bh2smith bh2smith mentioned this pull request May 7, 2024
@bh2smith bh2smith merged commit f9aaa17 into main May 7, 2024
1 check passed
@bh2smith bh2smith deleted the extract-signature branch May 7, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant