Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up Tests and CI #32

Closed
bh2smith opened this issue May 7, 2024 · 1 comment
Closed

Clean Up Tests and CI #32

bh2smith opened this issue May 7, 2024 · 1 comment

Comments

@bh2smith
Copy link
Collaborator

bh2smith commented May 7, 2024

As of #29, there are some "unit" tests that should be marked as integration tests and CI doesn't currently run the e2e tests at all (since the MPC contract is not returning signatures). We should rework this -- maybe only run e2e tests on merge to main.
@bh2smith
Copy link
Collaborator Author

bh2smith commented Aug 9, 2024

There are very few tests of this sort anymore (all unit tests are now only sometimes "reading" the mpc contract), but generally this is not expected to become an urgent concern any time soon. Closing now as "good enough"

@bh2smith bh2smith closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bh2smith