Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Width Format #775

Merged
merged 2 commits into from
May 19, 2022

Conversation

enyipreshious
Copy link
Contributor

Reformated Image by removing the line layout= "full-width" from the .md file. This PR is an issue to #746

Reformated Image by changing it from a full width lsyout to a fixed width
Copy link
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on the website @enyipreshious!

  • Could you please remove the empty line at 53? No need to leave it there with only whitespace.
  • Also, since we are now displaying the image smaller, we should probably downsize the image to 880 px wide. It can be exported from Figma at a smaller size from this file. Let me know if you need help with that,

@@ -50,7 +50,7 @@ Two main types of information need to be backed up: the user's wallet recovery d
alt-text = "A diagram of data required to back up a bitcoin wallet"
width = 1200
height = 680
layout = "full-width"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the layout attribute has been removed, could you remove this line entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you your help @sbddesign. Do you know how I can link the image in the .md file on my end after exporting from figma?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best way to handle it is to simply save over the old image file with the same filename.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to remove the entry from the compress_image_cache-yml so it compresses the new image if you do that though

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the whitespace and resized the image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -50,7 +50,7 @@ Two main types of information need to be backed up: the user's wallet recovery d
alt-text = "A diagram of data required to back up a bitcoin wallet"
width = 1200
height = 680
layout = "full-width"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the whitespace and resized the image

@sbddesign sbddesign merged commit 3edd033 into BitcoinDesign:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants