-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Width Format #775
Image Width Format #775
Conversation
Reformated Image by changing it from a full width lsyout to a fixed width
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good on the website @enyipreshious!
- Could you please remove the empty line at 53? No need to leave it there with only whitespace.
- Also, since we are now displaying the image smaller, we should probably downsize the image to 880 px wide. It can be exported from Figma at a smaller size from this file. Let me know if you need help with that,
@@ -50,7 +50,7 @@ Two main types of information need to be backed up: the user's wallet recovery d | |||
alt-text = "A diagram of data required to back up a bitcoin wallet" | |||
width = 1200 | |||
height = 680 | |||
layout = "full-width" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the layout attribute has been removed, could you remove this line entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you your help @sbddesign. Do you know how I can link the image in the .md file on my end after exporting from figma?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the best way to handle it is to simply save over the old image file with the same filename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to remove the entry from the compress_image_cache-yml
so it compresses the new image if you do that though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the whitespace and resized the image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -50,7 +50,7 @@ Two main types of information need to be backed up: the user's wallet recovery d | |||
alt-text = "A diagram of data required to back up a bitcoin wallet" | |||
width = 1200 | |||
height = 680 | |||
layout = "full-width" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the whitespace and resized the image
Reformated Image by removing the line layout= "full-width" from the .md file. This PR is an issue to #746