Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image on Backup & Recovery page less imposing #746

Closed
GBKS opened this issue Apr 6, 2022 · 7 comments
Closed

Make image on Backup & Recovery page less imposing #746

GBKS opened this issue Apr 6, 2022 · 7 comments
Labels
Daily spending wallet Referring to the Daily spending wallet reference design section. Design Task is about designing something. Good first issue Good for newcomers

Comments

@GBKS
Copy link
Contributor

GBKS commented Apr 6, 2022

Via this comment.

Live page.

@GBKS GBKS added Good first issue Good for newcomers Design Task is about designing something. labels Apr 6, 2022
@Bosch-0
Copy link
Collaborator

Bosch-0 commented Apr 11, 2022

This issue could be part of our bigger milestone focusing on revising the newly formed Daily spending wallet reference design we now have in the guide.

@Bosch-0 Bosch-0 added the Daily spending wallet Referring to the Daily spending wallet reference design section. label Apr 11, 2022
@Bosch-0 Bosch-0 changed the title Make image on "Backup & Recovery" page less imposing Make image on Backup & Recovery page less imposing Apr 11, 2022
@enyipreshious
Copy link
Contributor

I'd like to solve this. How do I go about it?

I have check the issue, and if I get it correctly the image size and colour doesn't blend well with the content.

I could recreate the illustration in figma and make appropriate changes

@Bosch-0
Copy link
Collaborator

Bosch-0 commented Apr 12, 2022

Here is the Figma file for that image: https://www.figma.com/file/q9EgLqOKcIVc0Cq7khtpNm/Onboarding-%3E-Backups?node-id=0%3A1 by @sbddesign

This can be found in the markdown file which if you go to Code at the top, go the guide -> Daily spending wallet -> Backup & recovery -> landing-page.md file you can see there is a illustration sources section at the top of the page.

Details on how to size the images can be found here: https://bitcoin.design/guide/contribute/illustration-guidelines/

If you need help opening the PR for this, happy to help!

@GBKS
Copy link
Contributor Author

GBKS commented Apr 12, 2022

The simplest option is to just remove the line layout = "full-width" from the markdown file. This line allows the image to size up. Removing it restricts the width to 800px, making it much smaller.

A second simple option could be to tone down the colors a bit (mostly the purple background). But up to you what you'd like to do.

@enyipreshious
Copy link
Contributor

Thank you @GBKS and @Bosch-0 for your help. The repo has been cloned on my computer to make the appropriate change. The option of removing the layout = "full-width" line is what I for. The purple colour seems to still work fine, so I left it at that.

Here are the two images for comparison. I also need help with PR
image
image

@sbddesign
Copy link
Collaborator

@enyipreshious Here is a good place to learn about making a PR. There is a video tutorial you can watch and instructions underneath the video. Let us know if you have any questions, we can help.

@GBKS
Copy link
Contributor Author

GBKS commented May 20, 2022

This is complete with the merge of #775.

@GBKS GBKS closed this as completed May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily spending wallet Referring to the Daily spending wallet reference design section. Design Task is about designing something. Good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants