Fix bug of divide and modulus not handling a 0 denominator with byte data type #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created anonymizer listener for anonymizing SQL queries through the new engine Signed-off-by: Matthew Wells <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
matthewryanwells
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey,
acarbonetto and
GumpacG
as code owners
acarbonetto
approved these changes
Jun 1, 2023
core/src/test/java/org/opensearch/sql/expression/operator/arthmetic/ArithmeticFunctionTest.java
Show resolved
Hide resolved
GumpacG
approved these changes
Jun 1, 2023
Signed-off-by: Matthew Wells <[email protected]>
forestmvey
approved these changes
Jun 1, 2023
Codecov Report
@@ Coverage Diff @@
## integ-byte-bug #272 +/- ##
=================================================
Coverage 97.27% 97.28%
- Complexity 4330 4332 +2
=================================================
Files 388 388
Lines 10807 10809 +2
Branches 761 761
=================================================
+ Hits 10513 10515 +2
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
matthewryanwells
changed the title
Yury-Fridlyand
approved these changes
Jun 2, 2023
MitchellGale
pushed a commit
that referenced
this pull request
Jun 15, 2023
… (opensearch-project#1716) * Fixed bug of byte/short values not handling divide/modulus arithmetic equations Signed-off-by: Matthew Wells <[email protected]>
MitchellGale
pushed a commit
that referenced
this pull request
Jun 21, 2023
… (opensearch-project#1716) (opensearch-project#1734) * Fixed bug of byte/short values not handling divide/modulus arithmetic equations Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit 2c80631) Co-authored-by: Matthew Wells <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously there was no handling of a 0 denominator for byte in the divide and modulus arithmetic operators, I have fixed that and updated it's testing.
Issues Resolved
opensearch-project#1582
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.