[Backport 2.x] Fixed bug of byte/short not handling 0 denominator in divide/modulus equations #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
… (#1716) * Fixed bug of byte/short values not handling divide/modulus arithmetic equations Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit 2c80631)
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Yury-Fridlyand
approved these changes
Jun 13, 2023
MaxKsyunz
approved these changes
Jun 13, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1734 +/- ##
=========================================
Coverage 97.30% 97.30%
- Complexity 4328 4330 +2
=========================================
Files 385 385
Lines 10809 10811 +2
Branches 762 762
=========================================
+ Hits 10518 10520 +2
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
forestmvey
approved these changes
Jun 15, 2023
acarbonetto
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2c80631 from #1716