Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added limitations and issues table to connector markdown file #22

Merged
6 commits merged into from
Jan 8, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions bi-connectors/PowerBIConnector/docs/AmazonOpenSearchService.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,16 @@
2. Check if auth credentials are correct.
3. Check if server is running.

## Limitations and issues

There are known limitations and issues that are tracked by OpenSearch including the items listed below.

| Issue | Description |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues should link to existing GitHub tickets.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in e89be25

| ---- | ----------- |
| Visualizations without numerical columns | Visualizations will only work if there is a numerical column included due to a known limitation in OpenSearch regarding subqueries. An exception to this would be visualizations with columns only of type string works as well. Can be tracked with this [bug](https://github.com/opensearch-project/sql/issues/347) |
| Visualizations with First or Last options selected do not work | <img src="img/pbi_issue_first_last.png" width="200"> |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't render correctly. But it may just be a github pr issue. Thought I would suggest we avoid pngs here as many developers would likely prefer text only.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in e89be25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versus "do not work" can we say "not yet supported"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in e89be25

| Visualizations with Minimum, Maximum, Standard deviation, Variance, or Median options selected do not work | <img src="img/pbi_issue_aggregation.png" width="200"> |
| Basic filtering limitations | Selecting more than one value does not work when using basic filtering. Due to the issue in the first row of this table, selecting one value for basic filtering when there is no numerical column does not work. |
| Top N filtering limitations | OpenSearch has limitations on subquery which prevents Top N filtering from working. More information can be found [here](https://opensearch.org/docs/latest/search-plugins/sql/limitation/). |
| Advanced filtering limitations | `does not contain` and `does not start with` filters for string columns do not work. All advanced filtering for numerical columns do not work except for `is` and `is blank`. All advanced filtering for date and time columns do not work except for `is blank` and `is not blank`.|
| Relative Date filtering limitations | Due to a known timestamp issue in OpenSearch, all relative date filtering fail to work. |
13 changes: 13 additions & 0 deletions bi-connectors/PowerBIConnector/docs/OpenSearchProject.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,16 @@
2. Check if auth credentials are correct.
3. Check if server is running.

## Limitations and issues

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limitations and Known Issues

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in e89be25


There are known limitations and issues that are tracked by OpenSearch including the items listed below.

| Issue | Description |
| ---- | ----------- |
| Visualizations without numerical columns | Visualizations will only work if there is a numerical column included due to a known limitation in OpenSearch regarding subqueries. An exception to this would be visualizations with columns only of type string works as well. Can be tracked with this [bug](https://github.com/opensearch-project/sql/issues/347) |
| Visualizations with First or Last options selected do not work | <img src="img/pbi_issue_first_last.png" width="200"> |
| Visualizations with Minimum, Maximum, Standard deviation, Variance, or Median options selected do not work | <img src="img/pbi_issue_aggregation.png" width="200"> |
| Basic filtering limitations | Selecting more than one value does not work when using basic filtering. Due to the issue in the first row of this table, selecting one value for basic filtering when there is no numerical column does not work. |
| Top N filtering limitations | OpenSearch has limitations on subquery which prevents Top N filtering from working. More information can be found [here](https://opensearch.org/docs/latest/search-plugins/sql/limitation/). |
| Advanced filtering limitations | `does not contain` and `does not start with` filters for string columns do not work. All advanced filtering for numerical columns do not work except for `is` and `is blank`. All advanced filtering for date and time columns do not work except for `is blank` and `is not blank`.|
| Relative Date filtering limitations | Due to a known timestamp issue in OpenSearch, all relative date filtering fail to work. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.