Added limitations and issues table to connector markdown file #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
ghost
requested a review
from 
Codecov Report
@@ Coverage Diff @@
## powerbi-main #22 +/- ##
===============================================
Coverage 99.90% 99.90%
Complexity 2691 2691
===============================================
Files 256 256
Lines 6533 6533
Branches 422 422
===============================================
Hits 6527 6527
Misses 5 5
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
added 2 commits
January 5, 2022 10:23
…or-limitation-documentation
…t-sql into connector-limitation-documentation
raymond-lum
reviewed
Jan 6, 2022
|
|
||
| There are known limitations and issues that are tracked by OpenSearch including the items listed below. | ||
|
|
||
| | Issue | Description | |
There was a problem hiding this comment.
Issues should link to existing GitHub tickets.
raymond-lum
reviewed
Jan 6, 2022
| | Issue | Description | | ||
| | ---- | ----------- | | ||
| | Visualizations without numerical columns | Visualizations will only work if there is a numerical column included due to a known limitation in OpenSearch regarding subqueries. An exception to this would be visualizations with columns only of type string works as well. Can be tracked with this [bug](https://github.com/opensearch-project/sql/issues/347) | | ||
| | Visualizations with First or Last options selected do not work | <img src="img/pbi_issue_first_last.png" width="200"> | |
There was a problem hiding this comment.
These don't render correctly. But it may just be a github pr issue. Thought I would suggest we avoid pngs here as many developers would likely prefer text only.
raymond-lum
reviewed
Jan 6, 2022
| @@ -64,3 +64,16 @@ | |||
| 2. Check if auth credentials are correct. | |||
| 3. Check if server is running. | |||
|
|
|||
| ## Limitations and issues | |||
raymond-lum
reviewed
Jan 6, 2022
| | Issue | Description | | ||
| | ---- | ----------- | | ||
| | Visualizations without numerical columns | Visualizations will only work if there is a numerical column included due to a known limitation in OpenSearch regarding subqueries. An exception to this would be visualizations with columns only of type string works as well. Can be tracked with this [bug](https://github.com/opensearch-project/sql/issues/347) | | ||
| | Visualizations with First or Last options selected do not work | <img src="img/pbi_issue_first_last.png" width="200"> | |
There was a problem hiding this comment.
Versus "do not work" can we say "not yet supported"
added 2 commits
January 6, 2022 10:49
…s to issues listed Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
raymond-lum
approved these changes
Jan 8, 2022
matthewryanwells
pushed a commit
that referenced
this pull request
Aug 22, 2023
…arch-project#2005) * Spotless apply on entire project Signed-off-by: Mitchell Gale <[email protected]> * Spotless apply Signed-off-by: Mitchell Gale <[email protected]> * Added spotless in sql-test-workflow.yml Signed-off-by: Mitchell Gale <[email protected]> * fixed error log message in sql-test-workflow.yml Signed-off-by: Mitchell Gale <[email protected]> * Added spotless to plugins: common, core, doctest, integ-test, legacy, opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <[email protected]> * Update common/build.gradle Signed-off-by: Mitchell Gale <[email protected]> * deleted duplicated code in build gradle integ test Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guian Gumpac [email protected]
Description
Added limitations and issues table to connector markdown file for users' and developers' knowledge.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.