[wallet] fixed keyboard type #533
Conversation
Release/1.1.0
Fix/wallet design
Release/1.1.0
Fix/settings design
Feature/messages loading
…ly used for all lists.
[chat] Contacts picker
…/Bit-Nation/BITNATION-Pangea-mobile into fix/wallet-insufficent-funds-487
…tion/BITNATION-Pangea-mobile into fix/delete-document-alert
[documents] Added Confirm Alert while deleting document
[documents] Fixed Close Menu Modal Bug
Fix/android splash ratio
Fix/wallet insufficent funds 487
|
Did you test this on different versions of the OS? Because sometimes the keyboard appearance changes depending the OS version with unexpected results in RN |
|
@albertoestarrona yes, look like we have this issue facebook/react-native#17473, but I don't have HTC or Samsung device to test on. This issue will be fixed with the last version of react-native as in the post says. So, I think we could update version of RN later to fix this. |
| @@ -167,7 +167,7 @@ class SendMoney extends NavigatorComponent<Props, State> { | |||
| placeholderTextColor={Colors.placeholderTextColor} | |||
| onChangeText={amountString => this.setState({ amountString })} | |||
| value={this.state.amountString} | |||
| keyboardType='decimal-pad' | |||
There was a problem hiding this comment.
As you specified on PR description:
Fixed keyboards for numbers are still alphanumeric, they should be numeric keypads.
Does it mean that decimal-pad set before produce alphanumeric keyboard? I believe we have changed it from numeric to decimal-pad intentionally so that it works consistent between iOS and Android. So, can you please specify a bit more, what exactly are you trying to fix (screenshot of previous incorrect behavior would be great).
There was a problem hiding this comment.
@seland I think this PR need to be postponed because I have fixed it on the android keyboard, before the fix it will be the alphanumeric keyboard as you see in the photo below. But because of the issue facebook/react-native#17473, I'm not potential it could fix for all android devices. So we need more research and testing on this case
|
Closed due to necessary rewrite of the history, to remove the abomination which was the stored 100 MB binary (which was also frequently changing). Please re-open the PR. Sorry for the inconvenience. |
Changes
Fixed keyboards for numbers are still alphanumeric, they should be numeric keypads.
Keyboard for password or passcode should have a check mark for “submit” (like the Android PIN keypad for unlocking the phone).
** Not fix- pending issues
-- after sending money, the wallet does show the same amount as before. Perhaps it does not update until the transaction clears? It should be immediately reduced, and if the transaction fails, restore the failed amount.
Issue #519